Skip to content

Conversation

oleibman
Copy link
Collaborator

Coveralls recommends using an "official integration" of their product with Github. Also, allow the upload to fail without causing the whole coverage step to fail - there have been some recent problems which they are still working on. I may allow the step to fail once they are done with their changes.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • support software

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Coveralls recommends using an "official integration" of their product with Github. Also, allow the upload to fail without causing the whole coverage step to fail - there have been some recent problems which they are still working on. I may allow the step to fail once they are done with their changes.
@oleibman oleibman added this pull request to the merge queue Sep 25, 2025
Merged via the queue into PHPOffice:master with commit 4fc82f4 Sep 25, 2025
14 checks passed
@oleibman oleibman deleted the tweakcoveralls branch September 26, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant