Create update_registration_encounter_datetimes,sql #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
reviewed
Aug 19, 2022
There was a problem hiding this comment.
The file itself looks fine @dmdesimone . I think the right location for this file is in the openmrs-config-zl repository (since this is a ZL-specific migration), and I think we should put it in a new folder at "configuration/pih/migrations". We should add a README.md to this folder basically indicating that this folder contains data migration scripts that were not executed by liquibase but as one-off updates. And then we should add comments to the top of this SQL file that explains what it does and why, and points back to the source ticket. Doable?
|
Will do, @mseaton ! thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.