Skip to content

Allow Configuring Additional Navigation Items #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: SearchConfigOptions
Choose a base branch
from
Open

Allow Configuring Additional Navigation Items #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/Filament/Panels/KnowledgeBasePanel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Filament\Navigation\NavigationItem;
use Filament\Pages\Dashboard;
use Filament\Panel;
use Filament\Panel\Concerns\HasComponents;
use Filament\Support\Assets\Theme;
use Filament\Support\Enums\Platform;
use Filament\View\PanelsRenderHook;
Expand Down Expand Up @@ -46,6 +47,7 @@ class KnowledgeBasePanel extends Panel
use CanDisableDefaultClasses;
use HasAnchorSymbol;
use HasArticleClass;
use HasComponents;

protected bool $guestAccess = false;
protected static bool $syntaxHighlighting = false;
Expand Down Expand Up @@ -259,8 +261,15 @@ protected function setUp(): void
)
)

// TODO: Replace with ->navigationItems and ->navigationGroups to support custom pages
->navigation($this->makeNavigation(...))
->navigation(function (NavigationBuilder $builder): NavigationBuilder {
// First add all standard navigation items
foreach ($this->getNavigationItems() as $navigationItem) {
$builder->item($navigationItem);
}

// Then add the dynamic KB navigation items
return $this->addKnowledgeBaseNavigation($builder);
})
;
}

Expand Down Expand Up @@ -289,7 +298,7 @@ protected function buildNavigationItem(Documentable $documentable): NavigationIt
;
}

protected function makeNavigation(NavigationBuilder $builder): NavigationBuilder
protected function addKnowledgeBaseNavigation(NavigationBuilder $builder): NavigationBuilder
{
$documentables = KnowledgeBase::model()::all();

Expand Down