feat: Add more options for ping passthrough #1631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…through-dev) * Added 'ALLBUTVERSION' option for ping passthrough. * Trying to get the GitHub build action to run * Added more configuration options for ping passthrough. * Updated default velocity.toml * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Add support for the legacy ping passthrough. --------- Co-authored-by: TheMiningTeamYT <[email protected]> Co-authored-by: powercas_gamer <[email protected]>
- Bumped config-version to 2.8 - Updated comments and grammar - Removed legacy ping passthrough in the config
|
I'll be honest, after several months of nothing happening I gave up on my pull request ever getting merged, so I stopped paying attention XD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo,
This is an updated version of this pull request with added config migrations and removal of dead code. The original author of these changes doesn't appear to be responsive as of late, so I've made a new pull request with my additional changes. Please let me know if there is anything you would like me to modify or add, I'd be happy to make any code changes to hopefully see this get merged.
Thank you :D