Skip to content

adds active_background property to buttons #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

adds active_background property to buttons #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a2da71
adds active_background property to buttons, but does not seem to alte…
jvendegna Sep 4, 2021
b0dc38e
adds frame to button object init method
jvendegna Sep 6, 2021
6a553f9
Merge remote-tracking branch 'origin/master' into bugfix/#127-button-…
jvendegna Sep 6, 2021
b75ee3c
adds cli build test as a make target
jvendegna Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@ precommit: lint test
cli:
poetry run tkdesigner ${FIGMA_PROJECT_URL} ${FIGMA_TOKEN} -f

cli.build.test:
poetry run tkdesigner https://www.figma.com/file/WVLnulVsI177tvnxSdqOUZ/Untitled ${FIGMA_TOKEN} -f

Comment on lines +31 to +33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you remove this link for that external dependency because this maybe to cause failures in the next builds if this resource does unavailable.

gui:
poetry run python gui/gui.py
2 changes: 2 additions & 0 deletions tkdesigner/figma/custom_elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def __init__(self, node, frame, image_path, *, id_):
super().__init__(node, frame)
self.image_path = image_path
self.id_ = id_
self.frame = frame

def to_code(self):
return f"""
Expand All @@ -20,6 +21,7 @@ def to_code(self):
image=button_image_{self.id_},
borderwidth=0,
highlightthickness=0,
activebackground="{self.frame.color()}",
command=lambda: print("button_{self.id_} clicked"),
relief="flat"
)
Expand Down