Skip to content

Conversation

premlingayat
Copy link

@premlingayat premlingayat commented Aug 26, 2025

This PR improves the user experience of the --generate-hosts-file module by adding a successfully generated hosts file message once the file is created.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)

Setup guide for the review

NA

Screenshots (if appropriate):

nxc

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • New and existing e2e tests pass locally with my changes
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

@premlingayat premlingayat changed the title My feature branch Show hosts file saved message. Aug 26, 2025
@premlingayat premlingayat changed the title Show hosts file saved message. Show hosts file successfully saved message. Aug 26, 2025
@NeffIsBack
Copy link
Member

Thanks for the PR, but here we definitely have the problem that this would be run against multiple hosts :)
Imo that is too much output

@Marshall-Hallenbeck
Copy link
Collaborator

Yeah this'll post the same thing over and over again for every host... what exactly is the point of it? The user is providing the file to save to and there's not any other information.

@premlingayat
Copy link
Author

Sometimes it doesn't save and sometimes it does with no feedback to user. This is to know if the tool saved it or just exited without saving.

@Marshall-Hallenbeck
Copy link
Collaborator

@premlingayat the problem is it will say this for each host, not just a summary after the scan.

@NeffIsBack
Copy link
Member

Gonna close for now

@NeffIsBack NeffIsBack closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants