Skip to content

Fix email availability check in isAvailable method #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix email availability check in isAvailable method #48

wants to merge 1 commit into from

Conversation

Hadyosman1
Copy link

Description

Fixed email availability check in isAvailable method to correctly compare with null instead of undefined.

Changes:

  • Updated isAvailable method to check findByEmail(dto.email) === null instead of undefined.
  • This fixes an issue where emails that were not registered before were incorrectly marked as unavailable (false).

Fixes #21

@Hadyosman1
Copy link
Author

Hi team 👋

This PR fixes an issue in the isAvailable method that caused emails to be incorrectly marked as unavailable. The fix was approved by @nicobytes ✅

Can someone with write access review and merge this PR? Thanks in advance! 🙏

Fixes: #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nicobytes nicobytes nicobytes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is-available route never responds with { "isAvailable": true }
2 participants
@Hadyosman1 @nicobytes