Skip to content

Conversation

MaxGhenis
Copy link
Collaborator

Summary

This PR adds comprehensive tests for the currency symbol fix that was directly pushed to master in commit e18e0f3.

Changes

  • Add unit tests for _get_prompt_template method
  • Test correct currency symbols for UK (£), US ($), CA ($), IL (₪), NG (₦)
  • Test fallback behavior for unknown countries

Testing

The tests verify that:

  • UK households see £ in AI explanations
  • US/Canadian households see $
  • Israeli households see ₪
  • Nigerian households see ₦
  • Unknown countries get generic markdown instructions

Related

  • Fixes the issue where UK AI explanations incorrectly displayed $ instead of £
  • Tests the changes from commit e18e0f3

🤖 Generated with Claude Code

- Test that UK uses £ symbol
- Test that US/CA use $ symbol
- Test that IL uses ₪ symbol
- Test that NG uses ₦ symbol
- Test fallback for unknown countries
- Ensures the fix in previous commit works correctly

🤖 Generated with Claude Code

Co-Authored-By: Claude <[email protected]>
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.56%. Comparing base (fae865f) to head (985a583).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
+ Coverage   80.42%   80.56%   +0.14%     
==========================================
  Files          49       49              
  Lines        1609     1616       +7     
  Branches      208      209       +1     
==========================================
+ Hits         1294     1302       +8     
  Misses        265      265              
+ Partials       50       49       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MaxGhenis and others added 2 commits August 26, 2025 22:02
- Apply Black formatting (79 char line limit)
- Add changelog_entry.yaml for version bumping

🤖 Generated with Claude Code

Co-Authored-By: Claude <[email protected]>
@MaxGhenis
Copy link
Collaborator Author

(my bad)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant