Create education page #161
Open
+71
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SakshiKekre
reviewed
Nov 4, 2025
| const location = useLocation(); | ||
|
|
||
| useEffect(() => { | ||
| document.title = "Educational use | PolicyEngine"; |
Collaborator
There was a problem hiding this comment.
Please don't set document.title manually. StaticPageLayout handles this via the <title> tag. This is redundant and inconsistent with other static pages.
SakshiKekre
requested changes
Nov 4, 2025
Collaborator
SakshiKekre
left a comment
SakshiKekre
left a comment
There was a problem hiding this comment.
Hi @SongmingFan123, thanks for your work on this! Could you please make the following changes?
- Rebase the branch on latest changes from main. The file is in src/pages/Education.page.tsx but should be in app/src/pages/Education.page.tsx. After rebasing, you'll also see that we have added a static layout for consistency across all static pages. Please use this StaticPageLayout wrapper instead of the custom Container/Center/Stack structure.
- The PR only adds the page file but doesn't add the route to Router.tsx. No navigation can reach this page. Please integrate the page in the app. This way we can look at the Vercel deployment to see how the page looks as you build it.
- Use the HeroSection component for the title/description and ContentSection component for sections.
- BulletsColumn is designed for report output columns, not static page lists. Please use Plain HTML
- (maybe inside RichTextBlock?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138