Benefit access page #264
Benefit access page #264
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
app/src/pages/BenefitAccess.page.tsx
Outdated
| title="Benefit Access" | ||
| description="Powering benefit eligibility screening tools through the PolicyEngine API" | ||
| /> | ||
| <Space mb={20} /> {} |
There was a problem hiding this comment.
Question: What is the purpose of the empty object after closing ?. This appears to be leftover development code.
Suggestion: Use Mantine's spacing props on surrounding components instead of adding extra spacing components.
There was a problem hiding this comment.
Thank you for your work on this, @Swetna! The page looks good overall. However, there have been some major updates to the codebase over the past couple of weeks. The current v2 pattern now uses:
- StaticPageLayout as the wrapper
- HeroSection for the title and description
- ContentSection for content blocks
- RichTextBlock with basic HTML for rich text
- Section dividers handled by ContentSection
Along with addressing the PR review comments, could you please rebase on the latest changes from main and update the PR accordingly?
Swetna
force-pushed
the
feat/benefit_access_page
branch
from
53e85e3 to
974ce6d
Compare
|
All updates have been made do let me know if everything looks ok. |
Created and formatted the Benefit Access page using the components.
Screenshot of page:
