Skip to content

Conversation

@arthurdedeus
Copy link
Contributor

@arthurdedeus arthurdedeus commented Oct 24, 2025

Problem

The Error Tracking setup prompt wasn't being shown in the Notebook Issues node, which meant users might not understand why they weren't seeing any error data or how to enable it.

Part of #40328

Changes

Added the ErrorTrackingSetupPrompt component to wrap the IssuesQuery component in the Notebook Node Issues view. This ensures users are prompted to enable exception autocapture if they haven't already.

Also enhanced the ErrorTrackingSetupPrompt component to accept an optional className prop, allowing for better styling control. This prop is passed through to the IngestionStatusCheck component.

image

How did you test this code?

Tested by:

  1. Creating a new project with Error Tracking not configured
  2. Verifying the setup prompt appears when exception autocapture is disabled
  3. Enabling exception autocapture and confirming the issues view appears correctly

Copy link
Contributor Author

arthurdedeus commented Oct 24, 2025

@arthurdedeus arthurdedeus requested review from a team, ablaszkiewicz, daibhin, hpouillot, oliverb123 and rafaeelaudibert and removed request for a team October 24, 2025 17:43
@arthurdedeus arthurdedeus self-assigned this Oct 24, 2025
@arthurdedeus arthurdedeus marked this pull request as ready for review October 24, 2025 17:45
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 3.32 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.32 MB

compressed-size-action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor Author

arthurdedeus commented Oct 27, 2025

Merge activity

  • Oct 27, 12:25 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 27, 12:26 PM UTC: @arthurdedeus merged this pull request with Graphite.

@arthurdedeus arthurdedeus merged commit 0aa7d3b into master Oct 27, 2025
150 of 151 checks passed
@arthurdedeus arthurdedeus deleted the feat/notebook-node-cta-error-tracking branch October 27, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants