Migrate cryptography to rust #74
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes with many benefits such as: - Speed. In fact, in our testing, backup times are slashed to under a second for 100 notes in debug mode. This can be improved by reducing memory copying and enabling hardware AES and SIMD in `rustc` flags. - Auditability. We use audited cryptography libraries such as `ring` and `aes-gcm` which provide better security. - Predictability. Due to the lack of a runtime, boxing and unboxing, the speed is predictable reducing many attacks which depend on timing information. The libraries are made to be run in constant-time which further improves security. Todo: - [ ] Setup build scripts to use hardware AES and SIMD when available - [ ] Remove debug log statements I added for testing - [ ] Improve error checking on the rust side - [ ] Setup build scripts for other platforms like `Linux`, `iOS`, `Android` and `macOS`. Current scripts only integrate with `windows`. Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
This relies on a build script hack as `cargo-xcode` uses wrong triplets for iOS simulator on x86_64 hosts. Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
It still needs testing though Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
Signed-off-by: Akshit Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with many benefits such as:
Speed. In fact, in our testing, backup times are slashed to under a
second for 100 notes in debug mode. This can be improved by reducing
memory copying and enabling hardware AES and SIMD in
rustcflags.Auditability. We use audited cryptography libraries such as
ringandaes-gcmwhich provide better security.Predictability. Due to the lack of a runtime, boxing and unboxing, the
speed is predictable reducing many attacks which depend on timing
information. The libraries are made to be run in constant-time which
further improves security.
Todo
x86_64-pc-msvc-windowsx86_64-linux-androidaarch64-linux-androidarmv7-linux-androideabix86_64-apple-iosx86_64-apple-darwinaarch64-apple-iosaarch64-apple-ios-simPerform final compatibility testing (some old backups fail to restore,Implementations are 100% compatible. The system errors out withList<int>toUint8Listissue migration suspected).nullfolder,last_changed. Need to retain backwards compatibility with old backups @HrX03Signed-off-by: Akshit Garg [email protected]