STACK: Fix relative links returned by API in JS library #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeezer
pushed a commit
that referenced
this pull request
Oct 17, 2025
|
Merged as-is. Thanks. |
|
Generally, it'd be easier to not have duplicate commits across more than one PR. If I make edits to ones that have been merged, hten they won't match up. I know how to deal with that case, it just would be better if it wasn't this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STACK API sometimes returns links to assets that should be displayed in the question.
These links are relative to the URL of the STACK API; however, when directly rendering them on a website, they will be interpreted as relative to the website, and thus not work.
This fixes it but prefixing the URL of the STACK API.
This PR build on top of #2693 in order to avoid merge conflicts (both PRs touch the same part of the STACK JS file). Only the last commit is new. Merging this PR will also merge #2693