Skip to content

Add Face autocalibration. #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add Face autocalibration. #133

wants to merge 8 commits into from

Conversation

RedInJector
Copy link
Collaborator

зображення

@RedInJector
feat: Face autocalibration
2c873a1 
- implementation of the same algorithm used in the legacy app
@dfgHiatus
Copy link
Collaborator

I'm not seeing the autocalibration option at the top of the calibration page here?

image

@dfgHiatus dfgHiatus self-assigned this Sep 18, 2025
@dfgHiatus dfgHiatus added the enhancement New feature or request label Sep 18, 2025
@dfgHiatus
Copy link
Collaborator

Also, I don't seem to have src/Baballonia/Views/CalibrationView.axaml checked out as part of this PR. Maybe rebase, see if that helps?

dfgHiatus
dfgHiatus requested changes Sep 18, 2025
View reviewed changes
src/Baballonia/Services/ParameterSenderService.cs
{
if (expressions == null) return;
if (expressions.Length == 0) return;
Debug.Assert(expressions != null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these Debug.Asserts, or change them to throw an exception instead.

@SummerSigh
Copy link
Member

I'm not seeing the autocalibration option at the top of the calibration page here?

image

im fairly sure it would be in the settings page

@SummerSigh
Copy link
Member

wait nvm

@SummerSigh
Copy link
Member

FYI i wrote the algorithm and it worked on me, but wider deployment showed issues, Maybe a simple min max autocalibration with a slow decay on the min side (min side decays to 0.5 or something) would make it work better on more people?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfgHiatus dfgHiatus dfgHiatus requested changes

Assignees

@dfgHiatus dfgHiatus

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RedInJector @dfgHiatus @SummerSigh