Fix multiple definition of fp1 #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chinhpham204719
force-pushed
the
fix_fp1_multiple_definition
branch
18 times, most recently
from
6cdb408 to
baa42da
Compare
archlitchi
reviewed
Jun 19, 2025
There was a problem hiding this comment.
Why add another .h file, can we move these to log_utils.h?
Chinhpham204719
force-pushed
the
fix_fp1_multiple_definition
branch
from
baa42da to
8812c89
Compare
Related: Project-HAMi#75 Signed-off-by: ChinhPham <[email protected]>
Chinhpham204719
force-pushed
the
fix_fp1_multiple_definition
branch
from
8812c89 to
10c48f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the multiple definition of the global
fp1used for logging, which caused linking errors when building modules likeshrreg-toolandlibvgpu.so.Changes
fp1_global.hto declareextern FILE *fp1;FILE *fp1;in headers or multiple source files with#include "fp1_global.h"FILE *fp1 = NULL;only once inlibvgpu.cRelated
Fixes #75