This repository was archived by the owner on May 27, 2021. It is now read-only.
Script vs Template Dependencies #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hutchgrant
changed the title
hutchgrant
force-pushed
the
fix-issue-71
branch
from
6e7dab6 to
ef28779
Compare
hutchgrant
commented
Feb 2, 2019
| @@ -62,7 +61,7 @@ module.exports = function (config) { | |||
| ] // https://github.com/Googlechrome/puppeteer/issues/290#issuecomment-322852784 | |||
| } | |||
| }, | |||
| singleRun: shouldSingleRun, | |||
| singleRun: true, | |||
There was a problem hiding this comment.
Problem here is that if we use NODE_ENV=production in circleci to determine if it should single run, the dev dependencies of the template app will not install properly which means karma won't install during our tests!
|
Moving to rfc-001 branch and closing. |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #71
Summary of Changes
See Issue #71