-
Notifications
You must be signed in to change notification settings - Fork 2
Add get_from() function to assist time-dependent control of separatrix density #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fmunguia-wulf
wants to merge
27
commits into
master
Choose a base branch
from
fix/optional-pedestal-density-tanh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rojectTorreyPines/IMAS.jl into origin/new-objective-functions
Enables separatrix density retrival from core_profiles and pulse_schedule: - get_from(dd, Val{:ne_sep}, :core_profiles) - get_from(dd, Val{:ne_sep}, :pulse_schedule)
Removed rho_sep as it does not get used.
Add fast density calculation to IMAS.sources Add max_fast_frac parameter to prevent thermal density becoming negative.
Undo "return refreeze" (not sure how that happened.
delete duplicate in get_from
diffusivities add calculation of to transport.jl
update syntax on get_from
Minor bug fix
minor bug fixed for fast ion quasineutrality
minor bug fix
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
IMAS.get_from()
functionality for:ne_separatrix
to be called inside ofpedestal_actor.jl
. This change is meant to satisfy the requirement that changes in FUSE PR #943 work for time-dependent simulations that are started from experimental data.