Add fast density calculation to IMAS.sources #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fast density calculation to IMAS.sources Add max_fast_frac parameter to prevent thermal density becoming negative.
Undo "return refreeze" (not sure how that happened.
diffusivities add calculation of to transport.jl
Minor bug fix
minor bug fixed for fast ion quasineutrality
minor bug fix
|
@orso82 I'm happy with the pull request now, and I think it's ready for this to be merged. |
orso82
reviewed
Sep 25, 2025
| q_density_difference = ne .- sum(ion.density .* avgZ(ion) for ion in cp1d.ion if ion !== ion0) | ||
| if hasdata(ion0, :density_fast) | ||
| q_density_difference .-= .-ion0.density_fast .* avgZ(ion0) | ||
| q_density_difference .-= ion0.density_fast .* avgZ(ion0) |
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
Co-authored-by: Orso Meneghini <[email protected]>
orso82
reviewed
Sep 26, 2025
|
@orso82 Can you verify that the refreezes in |
Remove refreezes from fast_particle_profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fast density calculation to IMAS.sources
Add max_fast_frac parameter to prevent thermal density becoming negative.