Apply averages to coil and magnetic data #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new averaging functions in an IMAS repo PR. The data is averaged over the same time window that is used in EFIT, which could be made into input variables if there is interest in more easily varying it. These averages are currently just over independent windows, which differs from EFIT and different options may be added in the future.
bclyons12
requested changes
Oct 17, 2025
There was a problem hiding this comment.
ProjectTorreyPines/IMAS.jl#280 is merged, but please address these comments.
There was a problem hiding this comment.
I don't think we should change the default behavior to be averaging. That's a specific use case. Often you just want the current at a specific time.
There was a problem hiding this comment.
Here I'm more fine with averaging for the flux loop since that's actual data that could be noisy. I suppose we should make sure that this doesn't have any issue with smooth, synthetic data or any need for causal averaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new averaging functions in the IMAS PR ProjectTorreyPines/IMAS.jl#280. The data is averaged over the same time window that is used in EFIT, which could be setup as input variables if there is interest in more easily varying it. These averages are currently just over independent windows, which differs from EFIT and alternative options may be added in the future.