Add support for SMB perf metrics #118
Conversation
tylergmuir
force-pushed
the
add-smb-metrics
branch
from
e07e213 to
38b6c1a
Compare
There was a problem hiding this comment.
There are a lot of things I like about this.
What I really hate about the Purity API is that if I query file-systems/performance?names=<FILESYSTEM_ONLY_ENABLED_FOR_SMB>&protocol=nfs It will show me results =0 even though it's not enabled for nfs.
Is it false, not quite, but it should not return a =null or not return a file system name.
For us to handle that you'd have to filter out the list of filesystems first and then have 2 lists for nfs, and smb. @tylergmuir is that something you want to do?
| @@ -11,15 +13,17 @@ func (fb *FBClient) GetFileSystemsPerformance(f *FileSystemsList, | |||
| protocol string) *FileSystemsPerformanceList { | |||
| uri := "/file-systems/performance" | |||
| result := new(FileSystemsPerformanceList) | |||
| const chunkSize = 10 | |||
There was a problem hiding this comment.
I like the idea of the chunkSize on this. I know the FlashBlade API limit on number of filesystems queried at once was recently changed from 5 to 10. Can we try with 10, and then if we get back an HTTP 400 error then reduce to 5?
Fixes #117
I mostly just mimicked what was already being done for the array perf metrics where we were presenting out a metric for each protocol and the cumulative metric under protocol "all".