Skip to content

Conversation

@robsdedude
Copy link
Contributor

@robsdedude robsdedude commented Oct 19, 2025

This amends #898 as tabs (\t) are also considered whitespace in Python.

Found while working on #1966

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (17746ba) to head (3d75057).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          40       40           
  Lines        3090     3090           
  Branches      680      680           
=======================================
  Hits         3065     3065           
  Misses         14       14           
  Partials       11       11           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Again, only one a comment about the typing in the test.

@robsdedude robsdedude force-pushed the fix/ws-insensitive-check branch from 58f3ac8 to 1199141 Compare October 23, 2025 18:24
@robsdedude
Copy link
Contributor Author

Type annotated and squashed. Ready for another review @DanielNoord

Copy link
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix that annotation!

@DanielNoord DanielNoord added this pull request to the merge queue Oct 24, 2025
Merged via the queue into PyCQA:main with commit 77bc665 Oct 24, 2025
21 checks passed
@robsdedude robsdedude deleted the fix/ws-insensitive-check branch October 24, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants