Skip to content

Conversation

@ItamarGoldman
Copy link

@ItamarGoldman ItamarGoldman commented Oct 20, 2025

Summary

Change the Jupyter Notebook and the python code to support Qiskit 2.x.
Issue #1676

Details and comments

This PR only changed the Qiskit related issues in the document. Now the circuit is going through a pass manager and the tutorial use Sampler and AerSimulator to run the circuit.

  • Fix Tutorial 1
  • Fix Tutorial 2
  • Fix Tutorial 4

@ItamarGoldman ItamarGoldman requested a review from a team as a code owner October 20, 2025 12:13
@Tansito
Copy link
Member

Tansito commented Oct 22, 2025

I don't know why in this PR the integration tests don't advance 🤔

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I am in the process of testing it. Most changes look good, so far I have some feedback regarding the aer simulator. In terms of the notebooks, I have noticed that the text needs to be updated in several points, and the code cells also need to be updated to make them runnable (like adding an instance parameter). Have you taken a look?

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update from running the examples: The notebooks are not runnable in their current state, they use outdated terms and outdated code. @ItamarGoldman, are you able to do a local deployment following these instructions https://qiskit.github.io/qiskit-serverless/deployment/local.html? This should allow you to run the given code and catch errors.

@Tansito
Copy link
Member

Tansito commented Oct 23, 2025

Another run that got stuck in the integration tests, it's only happening in this PR for whatever reason.

@ItamarGoldman
Copy link
Author

Closing this PR as a new PR was made under a branch of main and not under a forked repository.
The new PR is #1764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants