[Von Neumann] Updates Translations #62
Conversation
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Chinese translation of the von Neumann model documentation to improve consistency with the English version. The main purpose is to fix poorly-defined definition, assumption, and theorem environments that were inconsistent with the English version.
Key changes include:
- Improved formatting and consistency of mathematical definitions, assumptions, and theorems using proper markup
- Enhanced terminology consistency throughout the document
- Minor text refinements for clarity and precision
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| x_0^\top B &\geq \gamma^{* } x_0^\top A \\ | ||
| Bp_0 &\leq \gamma^{* } Ap_0 \\ | ||
| x_0^T\left(B-\gamma^{* } A\right)p_0 &= 0 | ||
|
|
||
| x_0^\top \left(B-\gamma^{* } A\right)p_0 &= 0 |
There was a problem hiding this comment.
[nitpick] Inconsistent use of ^\top vs ^T for transpose notation. The document uses both x^T (line 526) and x_0^\top (line 539). Consider standardizing to one notation throughout the document for consistency.
Copilot uses AI. Check for mistakes.
|
|
||
| \text{且}\quad\quad (e^i)^T C p^* \leq V(C)\quad \forall i\in\{1, \dots, m\} | ||
| (x^* )^\top C e^j \geq V(C)\quad \forall j\in\{1, \dots, n\}\quad \quad | ||
| \text{and}\quad\quad (e^i)^\top C p^* \leq V(C)\quad \forall i\in\{1, \dots, m\} |
There was a problem hiding this comment.
[nitpick] Mixed language in mathematical expressions. Line 596 uses English 'and' in a Chinese document. Consider using Chinese '且' for consistency with the rest of the document.
| \text{and}\quad\quad (e^i)^\top C p^* \leq V(C)\quad \forall i\in\{1, \dots, m\} | |
| \text{且}\quad\quad (e^i)^\top C p^* \leq V(C)\quad \forall i\in\{1, \dots, m\} |
Copilot uses AI. Check for mistakes.
|
|
||
| $$ | ||
| \begin{aligned} | ||
| &\max_{\alpha} \hspace{2mm} \alpha\\ | ||
| &\text{s.t. }\hspace{2mm}x^T B \geq \alpha x^T A | ||
| &\text{s.t. }\hspace{2mm}x^\top B \geq \alpha x^\top A |
There was a problem hiding this comment.
[nitpick] Inconsistent use of ^\top vs ^T for transpose notation. This line uses x^\top while other parts of the document use x^T. Consider standardizing the transpose notation throughout the document.
| &\text{s.t. }\hspace{2mm}x^\top B \geq \alpha x^\top A | |
| &\text{s.t. }\hspace{2mm}x^T B \geq \alpha x^T A |
Copilot uses AI. Check for mistakes.
This PR updates the translation in von_neumann_model.md.
The definition, assumption, and theorem environments are not well-defined, which is inconsistent with the English version.
Do not merge until we fix it.