use common static values for Vector2/Vector3/CFrame #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just quickly went through and replaced anything that was depreciated
* Update .gitignore for main branch * Remove clamp from spring * Fix spring utils
|
Looks great. We'll need to update luacheck to make this happen. And probably update selene too. And then we'll also want to update main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a recent release note
this pull request basically just replaces any instances where those static methods can be used over constructing a new datatype
here's a benchmark of the performance gains of using Vector3.zero instead of Vector3.new(...)
benchmarked on an Apple M1