Skip to content

feat: Add SetValue method to AttributeValue for assignment with cleanup #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add SetValue method to AttributeValue for assignment with cleanup #592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f45fcc
feat: Add SetValue method to AttributeValue for assignment with cleanup
KreatorKols Oct 1, 2025
da8d1ba
fix: Correct condition in SetValue method to use self.Value for compa…
KreatorKols Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/attributeutils/src/Shared/AttributeValue.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,22 @@ function AttributeValue.Observe<T>(self: AttributeValue<T>): Observable.Observab
return RxAttributeUtils.observeAttribute(self._object, self._attributeName, rawget(self :: any, "_defaultValue"))
end

--[=[
Allows you to set a value, and returns a clean up that resets to default value

@param value T
@return () -> () -- Cleanup
]=]
function AttributeValue.SetValue<T>(self: AttributeValue<T>, value: T)
self._object:SetAttribute(rawget(self :: any, "_attributeName"), value)

return function()
if self.Value == value then
self._object:SetAttribute(rawget(self :: any, "_attributeName"), rawget(self :: any, "_defaultValue"))
end
end
end

--[=[
The current property of the Attribute. Can be assigned to to write
the attribute.
Expand Down Expand Up @@ -124,7 +140,7 @@ end

function AttributeValue.__newindex<T>(self: AttributeValue<T>, index, value)
if index == "Value" then
self._object:SetAttribute(rawget(self :: any, "_attributeName"), value)
self:SetValue(value)
elseif index == "AttributeName" then
error("Cannot set AttributeName")
else
Expand Down
Loading