Skip to content

feat: allow to disable "end on process signal" handlers #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

feat: allow to disable "end on process signal" handlers #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ A [bunyan logger](https://github.com/trentm/node-bunyan) instance. Created by de
Sets the timeout (in ms) after that an idle connection is closed by the server
__Default:__ `0`

#### `endOnProcessSignal`
Whether to close ftp server and exit process on SIGTERM/SIGINT/SIGQUIT signals or not
__Default:__ `true`

## CLI

`ftp-srv` also comes with a builtin CLI.
Expand Down
11 changes: 7 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ class FtpServer extends EventEmitter {
whitelist: [],
greeting: null,
tls: false,
timeout: 0
timeout: 0,
endOnProcessSignal: true,
}, options);

this._greeting = this.setupGreeting(this.options.greeting);
Expand Down Expand Up @@ -70,9 +71,11 @@ class FtpServer extends EventEmitter {

const quit = _.debounce(this.quit.bind(this), 100);

process.on('SIGTERM', quit);
process.on('SIGINT', quit);
process.on('SIGQUIT', quit);
if (this.options.endOnProcessSignal) {
process.on('SIGTERM', quit);
process.on('SIGINT', quit);
process.on('SIGQUIT', quit);
}
}

get isTLS() {
Expand Down