fix(create): clean up tmp folder before exit 😸

[gioboa]

Close #7351

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos
• Infra

Description

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I made corresponding changes to the Qwik docs
• I added new tests to cover the fix / functionality

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3dd0e4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	3dd0e4c

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7859

npm i https://pkg.pr.new/@builder.io/qwik-city@7859

npm i https://pkg.pr.new/eslint-plugin-qwik@7859

npm i https://pkg.pr.new/create-qwik@7859

commit: 3dd0e4c

[gioboa]

@Shane-Donlon Can you test the fix on Windows (with Linux and Mac it's working fine) with the new package please?

pnpm create qwik@https://pkg.pr.new/create-qwik@7859

[wmertens]

[Shane-Donlon]

@Shane-Donlon Can you test the fix on Windows (with Linux and Mac it's working fine) with the new package please?

pnpm create qwik@https://pkg.pr.new/create-qwik@7859

@gioboa Unfortunately still ongoing, but I did some digging on my side.
So the issue is that on abort the .create-qwikis still in use, and cannot be removed.

https://github.com/QwikDev/qwik/blob/main/packages/qwik/src/cli/utils/install-deps.ts#L87
If we change this to force remove the tmpInstallDir and your changes above I believe we're good to go (testing with PNPM link locally)

abort: () => abort().finally(() => fs.rmSync(tmpInstallDir, { recursive: true, force: true })),

Although I don't know if force removing it is an agreeable approach?!

[gioboa]

Thanks @Shane-Donlon for your check