Add push_asset_amount to OpenChannelRequest and update validation logic #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `push_asset_amount` field in OpenChannelRequest struct to handle asset pushes in RGB channels. - Updated validation to ensure `push_asset_amount` is only used with RGB channels and does not exceed `asset_amount`. - Modified channel opening logic to calculate local and remote amounts based on `push_asset_amount`. - Added tests for validating `push_asset_amount` functionality and error conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push_asset_amountfield in OpenChannelRequest struct to handle asset pushes in RGB channels.push_asset_amountis only used with RGB channels and does not exceedasset_amount.push_asset_amount.push_asset_amountfunctionality and error conditions.Closes #67