typo in env var list #4365
Open
typo in env var list #4365
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects documentation formatting by properly marking the pass name as code. The change applies proper reStructuredText code formatting to the rewrite_pooling pass name to maintain consistency with documentation standards.
- Applied proper code formatting to the
rewrite_poolingpass name using double backticks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
spolifroni-amd
requested changes
Oct 9, 2025
| * - | ``MIGRAPHX_REWRITE_LRN`` | ||
| | Turns on LRN-to-pooling lowering in the rewrite_pooling pass. | ||
| | Turns on LRN-to-pooling lowering in the ``rewrite_pooling`` pass. |
There was a problem hiding this comment.
This is a bit ambiguous. Is it turning on the lowering of LRN-to-pooling? Or is it turning on "LRN-to-pooling lowering"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modified env file to label a pass was code
Technical Details
From rewrite_pooling to
rewrite_poolingChangelog Category