-
-
Couldn't load subscription status.
- Fork 2.1k
[Build] Explicit Triple with LLVM 21.1.0 #17401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Explicit Triple with LLVM 21.1.0 #17401
Conversation
|
The Triple constructors only exist in llvm/llvm-project@fff720d#diff-5008de5706b85963c456532be4d2e8c5b478959be9d315f77c338946bd1fc586R353-R354 |
|
You can also leave it up as draft |
|
Is it possible to use ifdefs in the style of minimum version to build LLVM 19 and LLVM 21? This fixes the compilation error for LLVM triple on Windows Msys2 clang64 when wrapping all the explicit Triples. |
@qurious-pixel yes |
|
@Niram7777 if you can add the ifdefs, we can merge this |
3ad7fdc to
08065ce
Compare
08065ce to
6b15626
Compare
I just found there was #16807 but I have updated my PR in case you want to handle all LLVM versions and a quick fix |
|
With this commit and #17552, Clang should build again. |
Fix build error, the Triple constructor is not implicit anymore.
llvm/llvm-project@fff720d#diff-5008de5706b85963c456532be4d2e8c5b478959be9d315f77c338946bd1fc586R353-R354
[marin@pc-linux ~]$ clang++ --version
clang version 22.0.0git (https://github.com/llvm/llvm-project.git 1669bd3ae9af0cac4414479d8f1e53e329fa3efb)