Skip to content

t1-t2 only gains difftime class optionally #7237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

t1-t2 only gains difftime class optionally #7237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04f6e36
t1-t2 only gains difftime class optionally, for now
MichaelChirico Aug 6, 2025
23b8bff
mention option
MichaelChirico Aug 6, 2025
73549b9
doc options
MichaelChirico Aug 6, 2025
489fa04
rename: date->idate
MichaelChirico Aug 6, 2025
d0efdf0
tweak tests
MichaelChirico Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

1. `data.table(x=1, <expr>)`, where `<expr>` is an expression resulting in a 1-column matrix without column names, will eventually have names `x` and `V2`, not `x` and `V1`, consistent with `data.table(x=1, <expr>)` where `<expr>` results in an atomic vector, for example `data.table(x=1, cbind(1))` and `data.table(x=1, 1)` will both have columns named `x` and `V2`. In this release, the matrix case continues to be named `V1`, but the new behavior can be activated by setting `options(datatable.old.matrix.autoname)` to `FALSE`. See point 5 under Bug Fixes for more context; this change will provide more internal consistency as well as more consistency with `data.frame()`.

2. `t1 - t2`, where both `t1` and `t2` are `IDate`, will eventually have class `difftime`, consistent with the case where `t1` and `t2` are both `Date`. You can activate the new behavior by setting `options(datatable.old.diff.time = FALSE)`. See point 17 under Bug Fixes for more context.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to mention this option is only for temporary transition and should be generally avoided in favor of adapting code to the change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"you can activate the new behavior by setting ..." is confusing to me. Isn't the default for this option to not be set, so it gets value NULL, which means the code will set the class/units attributes? In that case the new behavior is already activated and you would have to deactivate it if you want by setting the option TRUE, right?


### NEW FEATURES

1. New `sort_by()` method for data.tables, [#6662](https://github.com/Rdatatable/data.table/issues/6662). It uses `forder()` to improve upon the data.frame method and also matches `DT[order(...)]` behavior with respect to locale. Thanks @rikivillalba for the suggestion and PR.
Expand Down
6 changes: 4 additions & 2 deletions R/IDateTime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,10 @@ chooseOpsMethod.IDate = function(x, y, mx, my, cl, reverse) inherits(y, "Date")
}
ans = as.integer(unclass(e1) - unclass(e2))
if (inherits(e2, "Date")) {
setattr(ans, "class", "difftime")
setattr(ans, "units", "days")
if (!isTRUE(getOption("datatable.old.diff.idate"))) {
setattr(ans, "class", "difftime")
setattr(ans, "units", "days")
}
} else {
setattr(ans, "class", c("IDate", "Date"))
}
Expand Down
3 changes: 2 additions & 1 deletion R/onLoad.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@
datatable.auto.index=TRUE, # DT[col=="val"] to auto add index so 2nd time faster
datatable.use.index=TRUE, # global switch to address #1422
datatable.prettyprint.char=NULL, # FR #1091
datatable.old.matrix.autoname=TRUE # #7145: how data.table(x=1, matrix(1)) is auto-named set to change
datatable.old.matrix.autoname=TRUE, # #7145: how data.table(x=1, matrix(1)) is auto-named set to change
datatable.old.diff.idate=TRUE # whether <IDate>-<IDate> gets difftime class set to change
)
opts = opts[!names(opts) %chin% names(options())]
options(opts)
Expand Down
18 changes: 11 additions & 7 deletions inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10342,7 +10342,7 @@ test(1673.1, TT + 4L, as.IDate("2016-04-29"))
test(1673.2, TT + 4, as.IDate("2016-04-29"))
test(1673.3, TT - 3, as.IDate("2016-04-22"))
test(1673.4, TT - 3L, as.IDate("2016-04-22"))
test(1673.5, all.equal(as.IDate("2016-04-28") - as.IDate("2016-04-20"), as.difftime(8, units='days')))
test(1673.5, options=c(datatable.old.diff.idate=FALSE), all.equal(as.IDate("2016-04-28") - as.IDate("2016-04-20"), as.difftime(8, units='days')))


# test for radix integer order when MAXINT is present AND decreasing=TRUE AND na.last=FALSE
Expand Down Expand Up @@ -21587,12 +21587,16 @@ test(2335.6, isoyear(as.Date("2019-12-30")), 2020L)
# t1-t2 for Date/IDate should be consistent, modulo storage mode #4979
t1 = as.IDate("2025-07-01")
t2 = as.IDate("2025-06-01")
test(2336.1, all.equal(as.Date(t1) - as.Date(t2), t1 - t2))
test(2336.2, all.equal(as.Date(t2) - as.Date(t1), t2 - t1))
test(2336.3, all.equal(as.Date(t1) - t2, t1 - t2))
test(2336.4, all.equal(as.Date(t2) - t1, t2 - t1))
test(2336.5, all.equal(t1 - as.Date(t2), t1 - t2))
test(2336.6, all.equal(t2 - as.Date(t1), t2 - t1))
test(2336.01, options=c(datatable.old.diff.idate=FALSE), all.equal(as.Date(t1) - as.Date(t2), t1 - t2))
test(2336.02, options=c(datatable.old.diff.idate=FALSE), all.equal(as.Date(t2) - as.Date(t1), t2 - t1))
test(2336.03, options=c(datatable.old.diff.idate=FALSE), all.equal(as.Date(t1) - t2, t1 - t2))
test(2336.04, options=c(datatable.old.diff.idate=FALSE), all.equal(as.Date(t2) - t1, t2 - t1))
test(2336.05, all.equal(t1 - as.Date(t2), t1 - t2))
test(2336.06, all.equal(t2 - as.Date(t1), t2 - t1))
test(2336.07, all.equal(as.numeric(as.Date(t1) - as.Date(t2)), as.numeric(t1 - t2)))
test(2336.08, all.equal(as.numeric(as.Date(t2) - as.Date(t1)), as.numeric(t2 - t1)))
test(2336.09, all.equal(as.numeric(as.Date(t1) - t2), as.numeric(t1 - t2)))
test(2336.10, all.equal(as.numeric(as.Date(t2) - t1), as.numeric(t2 - t1)))

# fwrite: allow dec=',' with single column, #7227
test(2337.1, fwrite(data.table(1), dec=","), NULL)
Expand Down
4 changes: 4 additions & 0 deletions man/data.table-options.Rd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@
expressions like \code{data.table(x=1, cbind(1))} will be named. When \code{TRUE}, it will be named
\code{V1}, otherwise it will be named \code{V2}.
}
\item{\code{datatable.old.diff.idate}}{Logical, default \code{TRUE}. Governs whether \code{t1 - t2},
where \code{t1} and \code{t2} are both class \code{IDate}, gains the S3 class \code{difftime}.
When \code{TRUE}, this class is assigned (with \code{units="days"}).
}
}
}

Expand Down
Loading