Skip to content

Conversation

venom1204
Copy link
Contributor

closes #2611

This PR fixes the long-standing bug in week() (#2611) by defining weeks sequentially: days 1–7 are week 1, days 8–14 week 2, etc.

hi @MichaelChirico @tdhock can you please have a review when you got time .
thanks.

Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (a837dc9) to head (8f6d2b2).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7274   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          81       81           
  Lines       15503    15503           
=======================================
  Hits        15351    15351           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

  • HEAD=issue____2611 slower P<0.001 for memrecycle regression fixed in #5463
  • HEAD=issue____2611 slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 8f6d2b2

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 56 seconds
Installing different package versions 9 minutes and 59 seconds
Running and plotting the test cases 2 minutes and 35 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdhock tdhock changed the title Fix week() calculation to start week 1 at days 1–7 (resolves #2611) Fix week() calculation to start week 1 at days 1–7 Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in week means first week only has 6 days?
2 participants