Skip to content

[CA-5313] Change return type during signup when identifier is not verified and option forbidUnverifiedIdentifierLoginAfterSignup is enabled #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CA-5313] Change return type during signup when identifier is not verified and option forbidUnverifiedIdentifierLoginAfterSignup is enabled #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/co/reachfive/identity/sdk/demo/JavaMainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import co.reachfive.identity.sdk.core.models.OpenIdUser;
import co.reachfive.identity.sdk.core.models.SdkConfig;
import co.reachfive.identity.sdk.core.models.requests.ProfileSignupRequest;
import co.reachfive.identity.sdk.core.models.responses.SignupResponse;
import co.reachfive.identity.sdk.facebook.FacebookProvider;
import co.reachfive.identity.sdk.google.GoogleProvider;
import co.reachfive.identity.sdk.webview.WebViewProvider;
Expand Down Expand Up @@ -103,7 +104,9 @@ public void onCreate(Bundle savedInstanceState) {
);
reach5.signup(
signupRequest,
this::handleLoginSuccess,
success -> {
showToast("test");
},
failure -> {
Log.d(TAG, "signup error=" + failure.getMessage());
showToast("Signup With Password Error " + failure.getMessage());
Expand Down
10 changes: 9 additions & 1 deletion src/main/java/co/reachfive/identity/sdk/demo/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import co.reachfive.identity.sdk.core.models.requests.ProfileSignupRequest
import co.reachfive.identity.sdk.core.models.requests.ProfileWebAuthnSignupRequest
import co.reachfive.identity.sdk.core.models.requests.StartStepUpLoginFlow
import co.reachfive.identity.sdk.core.models.requests.webAuthn.WebAuthnLoginRequest
import co.reachfive.identity.sdk.core.models.responses.SignupResponse
import co.reachfive.identity.sdk.demo.AuthenticatedActivity.Companion.AUTH_TOKEN
import co.reachfive.identity.sdk.demo.AuthenticatedActivity.Companion.SDK_CONFIG
import co.reachfive.identity.sdk.demo.databinding.*
Expand Down Expand Up @@ -188,7 +189,14 @@ class MainActivity : AppCompatActivity() {
this.reach5.signup(
profile = signupRequest,
redirectUrl = redirectUrlBinding.text.toString().ifEmpty { null },
success = { handleLoginSuccess(it) },
success = {
when(it) {
is SignupResponse.AchievedLogin -> handleLoginSuccess(it.authToken)
is SignupResponse.AwaitingIdentifierVerification -> {
showToast("Signup occurred but awaiting identifier verification")
}
}
},
failure = {
Log.d(TAG, "signup error=$it")
showErrorToast(it)
Expand Down