Better handling of key formatter for keyx that should remains in snakecase #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moust
commented
Apr 7, 2025
Comment on lines
+60
to
+69
| consents: { | ||
| optin_testing: { // consent key should remain in snakecase | ||
| granted: true, | ||
| consentType: "opt-in", | ||
| consentVersion: { | ||
| versionId: 1, | ||
| language: "fr" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Jusqu'à présent toutes les clés enfants étaient aussi conservés en snakecase.
Or on veut que leurs lés clés des consentements restent en snakecase, mais les propriétés comme consentType, consentVersion et versionId peuvent et devraient être converti en camelcase.
thomasreach5
approved these changes
Apr 8, 2025
sachaMemmir5
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatif à CA-4747 mais traité directement dans le SDK UI.
Ici il s'agit d'améliorer le fonctionnement pour que seul les clés concernés par l'exception soient gardés en snakecase mais pas les clés clés enfant. (voir modifications des test unitaire pour comprendre cette explication foireuse)
Néanmoins j'ai peur que ça introduise un breaking change pour d'éventuelles intégrations existantes...