[CA-5466] Pouvoir surcharger les messages i18n par langue #307
+463
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA-5466
Dans un premier temps j'ai modifié l'implémentation i18n existante. (cf. premier commit)
Néanmoins c'est une implémentation custom et j'ai voulu voir si il était possible de remplacer cette implémentation maison par l'utilisation de la librairie i18next (et son extension react-i18next pour React).
Au final c'était pas trop compliqué à faire et ça marche bien donc je pousse avec cette feature.
Au final ça apporte aussi quelques features appréciables comme :