Selector interception with arguments. #3286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
trigger-arguments
branch
from
04c7361 to
0e89e6a
Compare
andersio
changed the title
andersio
force-pushed
the
trigger-arguments
branch
from
4164707 to
06483b7
Compare
|
Oops, Travis isn't on Swift 3.0.1 yet. |
|
Had thought about emitting tuples. But IMO it doesn't add much in terms of type safety, since we cannot constraint against |
|
The disabled test cases in fe2f27c would be reenabled when changes in ReactiveCocoa/ReactiveObjC#33 is ported back. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #3285.Test coverage is limited.This PR adds
NSObject.reactive.signal(for:from:), which returns a signal that emits a collection of bridged arguments[Any?]after every invocation of the selector.It relies on the the
NSNumberandNSValuebridging introduced in Swift 3.0.1 to bridge values.NSInvocation & NSMethodSignature wrapperNSNumberinstead of Swift built-in types.NSValue.