Skip to content

Conversation

@zherman0
Copy link
Contributor

@zherman0 zherman0 commented Aug 29, 2025

Summary

Replace informational modal for recurring upgrades with alert. Currently a popup modal opens when the radio button for "Recurring updates" is selected and there is a manual upgrade already set. This modal basically acts as an acknowledge that said manual update will be removed. However, clicking the "Yes" button does nothing other than close the modal. Additionally, the other button just closes the modal and switches the radio button back to the individual option.

This is a pointless user interaction as it provides no additional information that a standard alert would not provide and more important it does not remove the scheduled upgrade. Only pressing save removes the upgrade.

Instead, I have now removed the modal popup all together. I added an inline alert (that matches the an existing alert) that states the individual upgrade will be removed (just as before), but now the user does not have to response to a NOOP modal window.

Jira

OCMUI-3720

How to Test

  1. Build a back level ROSA HCP cluster
  2. Go to the cluster details page -> settings
  3. Schedule a manual update (go through wizard)
  4. Once that is scheduled, click on the "Recurring updates" radio button.
  5. The recurring form with day and time will appear. Above that input will be a new inline alert that states the manual upgrade will be cancelled, along with the original information alert about control planes.

Screen Captures

Before After
Screenshot From 2025-08-26 16-48-50 Screenshot From 2025-08-29 14-47-29

Video of new process

Screencast.From.2025-08-29.15-04-18.mp4

Review process

Please review and follow the PR process.

QE Reviewer

  • Pre-merge testing : Verified change locally in a browser (downloaded and ran code using reviewx tool)
  • Updated/created Polarion test cases which were peer QE reviewed
  • Confirmed 'tc-approved' label was added by dev to the linked JIRA ticket
  • (optional) Updated/created Cypress e2e tests
  • Closed threads I started after the author made changes or added an explanation

@jira-linking
Copy link

jira-linking bot commented Aug 29, 2025

Commits missing Jira IDs:
4ba86d7

@zherman0 zherman0 self-assigned this Aug 29, 2025
Copy link
Collaborator

@kelvah kelvah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zherman0 Did you check with Nir before proceeding with this change?

This is not a bugfix anymore as you are not fixing the modal but removing it completely. You have to get UX approval to change things like this.

@zherman0
Copy link
Contributor Author

zherman0 commented Sep 2, 2025

@zherman0 Did you check with Nir before proceeding with this change?

This is not a bugfix anymore as you are not fixing the modal but removing it completely. You have to get UX approval to change things like this.

@kelvah - Thanks Roberto. Nir has looked at it now and we are on the same page. I left him a video to look at.

Copy link
Collaborator

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, switched between recurring and individual, with and w/o a 'manual scheduled job' in place, and also canceling the manually scheduled job and then switching between recurring and individual. The alert displayed and hidden as discussed in the ticket and this PR.
Code LGTM

@dtaylor113
Copy link
Collaborator

dtaylor113 commented Sep 3, 2025

Hi @zherman0, good job on not just 'fixing the bug' but looking at the bigger picture and realizing the modal should be an inline alert.
While I feel @kelvah 's comment that "You have to get UX approval to change things like this." is perhaps too strict to apply in all cases, it is always good to run it by UX who may see/consider things we don't. In this case however, I feel the solution was kinda obvious to any senior UI developer. -thanks

@zherman0 zherman0 requested review from DcooperRH and removed request for davidaznaur September 3, 2025 21:34
Copy link
Contributor

@DcooperRH DcooperRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, lgtm

@nirfarkas
Copy link

@zherman0 thanks! This looks great!
@dtaylor113 @kelvah this was discussed in the ticket and the inline was the UX change that was suggested.
Last thing,
I think we should change the Jira ticket name to:
Unexpected behaviour when switching between individual to recurring upgrades inside "Upgrade strategy" under cluster details "Settings"

@jmekkatt jmekkatt requested review from jloss-redhat and removed request for jmekkatt September 8, 2025 10:43
@zherman0 zherman0 merged commit 4ebae4e into RedHatInsights:main Sep 10, 2025
10 checks passed
meirinetta pushed a commit to meirinetta/uhc-portal that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants