- 
                Notifications
    
You must be signed in to change notification settings  - Fork 28
 
OCMUI-3720: Replace informational modal for recurring upgrades with alert #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Commits missing Jira IDs:  | 
    
        
          
                ...ponents/clusters/ClusterDetailsMultiRegion/components/UpgradeSettings/UpgradeSettingsTab.tsx
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zherman0 Did you check with Nir before proceeding with this change?
This is not a bugfix anymore as you are not fixing the modal but removing it completely. You have to get UX approval to change things like this.
          
 @kelvah - Thanks Roberto. Nir has looked at it now and we are on the same page. I left him a video to look at.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, switched between recurring and individual, with and w/o a 'manual scheduled job' in place, and also canceling the manually scheduled job and then switching between recurring and individual.  The alert displayed and hidden as discussed in the ticket and this PR.
Code LGTM
| 
           Hi @zherman0, good job on not just 'fixing the bug' but looking at the bigger picture and realizing the modal should be an inline alert.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, lgtm
| 
           @zherman0 thanks! This looks great!  | 
    
Summary
Replace informational modal for recurring upgrades with alert. Currently a popup modal opens when the radio button for "Recurring updates" is selected and there is a manual upgrade already set. This modal basically acts as an acknowledge that said manual update will be removed. However, clicking the "Yes" button does nothing other than close the modal. Additionally, the other button just closes the modal and switches the radio button back to the individual option.
This is a pointless user interaction as it provides no additional information that a standard alert would not provide and more important it does not remove the scheduled upgrade. Only pressing save removes the upgrade.
Instead, I have now removed the modal popup all together. I added an inline alert (that matches the an existing alert) that states the individual upgrade will be removed (just as before), but now the user does not have to response to a NOOP modal window.
Jira
OCMUI-3720
How to Test
Screen Captures
Video of new process
Screencast.From.2025-08-29.15-04-18.mp4
Review process
Please review and follow the PR process.
QE Reviewer