Switch to the async API and object_store_ffi infra #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vustef
commented
Sep 9, 2025
| @@ -84,7 +84,24 @@ fi | |||
| # Step 3: Run the integration test | |||
| print_status "Running integration test..." | |||
| echo "==========================================" | |||
| if ./integration_test; then | |||
|
|
|||
| # Determine the exact library filename | |||
vustef
commented
Sep 9, 2025
| ); | ||
|
|
||
| // Async function to initialize stream without getting first batch | ||
| export_runtime_op!( |
There was a problem hiding this comment.
Consider initializing the stream when it is created. This means we no longer need IcebergResponse
| } | ||
|
|
||
| // Helper function to create ArrowBatch from RecordBatch | ||
| // TODO: This should be zero-copy... | ||
| // TODO: Switch to zero-copy once Arrow.jl supports C API. |
There was a problem hiding this comment.
this op should happen in set_payload in IcebergBatchResponse.
src/lib.rs
Outdated
| } | ||
| } | ||
| }, | ||
| scan: *mut IcebergScan |
There was a problem hiding this comment.
consider implementing a method for IcebergScan so that the async block just calls that method
src/lib.rs
Outdated
| }); | ||
| // Backward compatibility function for error messages | ||
| #[no_mangle] | ||
| pub extern "C" fn iceberg_error_message() -> *const c_char { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.