Skip to content

Use path prefix as default prefix when loading models #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use path prefix as default prefix when loading models #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c546d
use path prefix as default behavior when loading models
NRHelmi Aug 4, 2022
55fc725
update changelog
NRHelmi Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Changelog

## main

* Add --prefix option to load-models
* Add get-model-source command
* Use models path as a default prefix (could be overwitten by --prefix flag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly is the semantic for use of paths in file names? aside from the prefix arg? eg: i assume we canonicalize paths in some way? what does ../foo/../bar/baz/model.rel do? what if its a path from home, eg: ~/bar/baz/model? and what about a fully qualified path? the original idea was to use the basename, and prepend any prefix provided by the prefix arg. simple and unambiguous. what use case does this not handle?


## V0.1.1

Expand Down
5 changes: 5 additions & 0 deletions rai/cmds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,11 +528,16 @@ func loadModels(cmd *cobra.Command, args []string) {
prefix := action.getString("prefix")
models := map[string]io.Reader{}
for _, arg := range args[1:] {
if !(cmd.Flags().Lookup("prefix").Changed) {
prefix, _ = filepath.Split(arg)
}

name := filepath.Join(prefix, baseSansExt(arg))
r, err := os.Open(arg)
if err != nil {
fatal(err.Error())
}

models[name] = r
}
if engine == "" {
Expand Down