Skip to content

Update JSON deserializer to handle new timestamp formats in promotions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update JSON deserializer to handle new timestamp formats in promotions #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a09bcd8
Update JSON deserializer to handle new timestamp formats in promotions
FE-hallen Sep 23, 2024
46301cb
Updated test data with new timestamps
FE-hallen Sep 23, 2024
8bb8592
Fixed edge cases for new timestamp parsing
FE-hallen Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions java-sdk-airtime/src/test/resources/operator/operator_auto_detect_filtered.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@
"title": "Digicel Haiti From 24 Dec 2020 00:00 To 31 Dec 2020 23:59 (GMT-05:00)",
"title2": "Bonus 3X to 4X",
"description": "<br />-&nbsp;The promotion will run from 00:01 am Thursday, December 24th 2020, through to and including 11:59 pm Thursday, December 31st 2020 (&ldquo;The Promotion Period&rdquo;).<br />- See below the participant denominations for this promotion:<br />&nbsp; &nbsp;- For USD$10 / CAD$ 15/ GBP$ 8 / Local Price 500 HTG, Customers will receive&nbsp; 200% Bonus Credit<br />&nbsp; &nbsp;- For&nbsp; USD$15 / CAD$ 20 /&nbsp; GBP$12 / Local Price 875 HTG, Customers will receive&nbsp; 300% Bonus Credit<br /><br />-&nbsp;The bonus minutes/credit is valid on the recipient&rsquo;s mobile number for a total of 3 days from when it is applied.<br />- The bonus credit on the recipient&rsquo;s Digicel mobile number can be used for Digicel to Digicel (on-net) calls only.<br />- Postpaid customers and Home and Entertainment customers are not eligible for the promotion.<br />- This promotion is only valid for Prepaid Digicel customers.<br />- Digicel will not be responsible for: (1) technical failures of any kind, including, but not limited to malfunctions, interruptions, or disconnections in network connections or hardware or software; (2) unauthorized human intervention in any part; or (3) technical or human error which may occur in the administration of this promotion.<br />- Digicel reserves the right to at any time vary the terms of the promotion, to amend its terms and conditions or to withdraw the promotion. In any of these events, notice will be given via media advertisements or messages to subscribers and will be effective immediately or as of the date referred to in such notifications.<br />- Digicel reserves the right to terminate, cancel, suspend and/or modify the promotion if any fraud, virus or other technical problem corrupts the administration, security, safety or proper play of the promotion. In such event, Digicel hereby specifically reserve the right (but not the obligation) to award some other prize hereunder by means of a random drawing from among the eligible entries received up until the time of the impairment.<br /><br /><img alt=\"\" src=\"https://i.postimg.cc/q7vQX0Xy/image001-69.png\" style=\"height:650px; width:650px\" />",
"startDate": "2020-12-24 10:00:00",
"endDate": "2021-01-01 09:59:00",
"startDate": "2020-12-24 10:00",
"endDate": "2021-01-01 09:59",
"denominations": "USD 10 and 15",
"localDenominations": null
},
Expand All @@ -101,8 +101,8 @@
"title": "Digicel Haiti From 01 Jan 2021 00:00 To 01 Jan 2021 23:59 (GMT-05:00)",
"title2": "Bonus 3X and 4X",
"description": "<br />- The promotion will run from 00:01 am Friday, January 1st 2021, through to and including 11:59 pm Friday, January 1st 2021 (&ldquo;The Promotion Period&rdquo;)<br />- For top ups of&nbsp; USD 10 / CAD 15 / GBP 8 / HTG 500 will receive 200% Bonus credit<br />- For top ups of&nbsp; USD 15 / CAD 20 / GBP 12 / HTG 875 will receive 300% Bonus credit<br />- The bonus minutes/credit is valid on the recipient&rsquo;s mobile number for a total of 3 days from when it is applied.<br />- The bonus credit on the recipient&rsquo;s Digicel mobile number can be used for Digicel to Digicel (on-net) calls and SMS only.<br />- Postpaid customers and Home and Entertainment customers are not eligible for the promotion.<br />- This promotion is only valid for prepaid Digicel customers.<br />- Digicel will not be responsible for: (1) technical failures of any kind, including, but not limited to malfunctions, interruptions, or disconnections in network connections or hardware or software; (2) unauthorized human intervention in any part; or (3) technical or human error which may occur in the administration of this promotion.<br />- Digicel reserves the right to at any time vary the terms of the promotion, to amend its terms and conditions or to withdraw the promotion. In any of these events, notice will be given via media advertisements or messages to subscribers and will be effective immediately or as of the date referred to in such notifications.<br />- Digicel reserves the right to terminate, cancel, suspend and/or modify the promotion if any fraud, virus or other technical problem corrupts the administration, security, safety or proper play of the promotion. In such event, Digicel hereby specifically reserve the right (but not the obligation) to award some other prize hereunder by means of a random drawing from among the eligible entries received up until the time of the impairment.<br /><br /><img alt=\"\" src=\"https://i.postimg.cc/65qDk2ST/Haiti-Independence-PNG.png\" style=\"height:650px; width:650px\" />",
"startDate": "2021-01-01 10:00:00",
"endDate": "2021-01-02 09:59:00",
"startDate": "2021-01-01T10:00:00Z",
"endDate": "2021-01-02 09:59:00Z",
"denominations": "USD 10 and up",
"localDenominations": null
}
Expand Down
8 changes: 4 additions & 4 deletions java-sdk-airtime/src/test/resources/operator/operator_auto_detect_unfiltered.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@
"title": "Digicel Haiti From 24 Dec 2020 00:00 To 31 Dec 2020 23:59 (GMT-05:00)",
"title2": "Bonus 3X to 4X",
"description": "<br />-&nbsp;The promotion will run from 00:01 am Thursday, December 24th 2020, through to and including 11:59 pm Thursday, December 31st 2020 (&ldquo;The Promotion Period&rdquo;).<br />- See below the participant denominations for this promotion:<br />&nbsp; &nbsp;- For USD$10 / CAD$ 15/ GBP$ 8 / Local Price 500 HTG, Customers will receive&nbsp; 200% Bonus Credit<br />&nbsp; &nbsp;- For&nbsp; USD$15 / CAD$ 20 /&nbsp; GBP$12 / Local Price 875 HTG, Customers will receive&nbsp; 300% Bonus Credit<br /><br />-&nbsp;The bonus minutes/credit is valid on the recipient&rsquo;s mobile number for a total of 3 days from when it is applied.<br />- The bonus credit on the recipient&rsquo;s Digicel mobile number can be used for Digicel to Digicel (on-net) calls only.<br />- Postpaid customers and Home and Entertainment customers are not eligible for the promotion.<br />- This promotion is only valid for Prepaid Digicel customers.<br />- Digicel will not be responsible for: (1) technical failures of any kind, including, but not limited to malfunctions, interruptions, or disconnections in network connections or hardware or software; (2) unauthorized human intervention in any part; or (3) technical or human error which may occur in the administration of this promotion.<br />- Digicel reserves the right to at any time vary the terms of the promotion, to amend its terms and conditions or to withdraw the promotion. In any of these events, notice will be given via media advertisements or messages to subscribers and will be effective immediately or as of the date referred to in such notifications.<br />- Digicel reserves the right to terminate, cancel, suspend and/or modify the promotion if any fraud, virus or other technical problem corrupts the administration, security, safety or proper play of the promotion. In such event, Digicel hereby specifically reserve the right (but not the obligation) to award some other prize hereunder by means of a random drawing from among the eligible entries received up until the time of the impairment.<br /><br /><img alt=\"\" src=\"https://i.postimg.cc/q7vQX0Xy/image001-69.png\" style=\"height:650px; width:650px\" />",
"startDate": "2020-12-24 10:00:00",
"endDate": "2021-01-01 09:59:00",
"startDate": "2020-12-24T10:00",
"endDate": "2021-01-01T09:59",
"denominations": "USD 10 and 15",
"localDenominations": null
},
Expand All @@ -86,8 +86,8 @@
"title": "Digicel Haiti From 01 Jan 2021 00:00 To 01 Jan 2021 23:59 (GMT-05:00)",
"title2": "Bonus 3X and 4X",
"description": "<br />- The promotion will run from 00:01 am Friday, January 1st 2021, through to and including 11:59 pm Friday, January 1st 2021 (&ldquo;The Promotion Period&rdquo;)<br />- For top ups of&nbsp; USD 10 / CAD 15 / GBP 8 / HTG 500 will receive 200% Bonus credit<br />- For top ups of&nbsp; USD 15 / CAD 20 / GBP 12 / HTG 875 will receive 300% Bonus credit<br />- The bonus minutes/credit is valid on the recipient&rsquo;s mobile number for a total of 3 days from when it is applied.<br />- The bonus credit on the recipient&rsquo;s Digicel mobile number can be used for Digicel to Digicel (on-net) calls and SMS only.<br />- Postpaid customers and Home and Entertainment customers are not eligible for the promotion.<br />- This promotion is only valid for prepaid Digicel customers.<br />- Digicel will not be responsible for: (1) technical failures of any kind, including, but not limited to malfunctions, interruptions, or disconnections in network connections or hardware or software; (2) unauthorized human intervention in any part; or (3) technical or human error which may occur in the administration of this promotion.<br />- Digicel reserves the right to at any time vary the terms of the promotion, to amend its terms and conditions or to withdraw the promotion. In any of these events, notice will be given via media advertisements or messages to subscribers and will be effective immediately or as of the date referred to in such notifications.<br />- Digicel reserves the right to terminate, cancel, suspend and/or modify the promotion if any fraud, virus or other technical problem corrupts the administration, security, safety or proper play of the promotion. In such event, Digicel hereby specifically reserve the right (but not the obligation) to award some other prize hereunder by means of a random drawing from among the eligible entries received up until the time of the impairment.<br /><br /><img alt=\"\" src=\"https://i.postimg.cc/65qDk2ST/Haiti-Independence-PNG.png\" style=\"height:650px; width:650px\" />",
"startDate": "2021-01-01 10:00:00",
"endDate": "2021-01-02 09:59:00",
"startDate": "2021-01-01T10:00:00Z",
"endDate": "2021-01-02T09:59:00Z",
"denominations": "USD 10 and up",
"localDenominations": null
}
Expand Down
8 changes: 4 additions & 4 deletions ...rtime/src/test/resources/operator/operators_by_country_code_filtered_exclude_bundles.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@
"title": "Digicel Haiti From 01 Jan 2021 00:00 To 01 Jan 2021 23:59 (GMT-05:00)",
"title2": "Bonus 3X and 4X",
"description": "<br />- The promotion will run from 00:01 am Friday, January 1st 2021, through to and including 11:59 pm Friday, January 1st 2021 (&ldquo;The Promotion Period&rdquo;)<br />- For top ups of&nbsp; USD 10 / CAD 15 / GBP 8 / HTG 500 will receive 200% Bonus credit<br />- For top ups of&nbsp; USD 15 / CAD 20 / GBP 12 / HTG 875 will receive 300% Bonus credit<br />- The bonus minutes/credit is valid on the recipient&rsquo;s mobile number for a total of 3 days from when it is applied.<br />- The bonus credit on the recipient&rsquo;s Digicel mobile number can be used for Digicel to Digicel (on-net) calls and SMS only.<br />- Postpaid customers and Home and Entertainment customers are not eligible for the promotion.<br />- This promotion is only valid for prepaid Digicel customers.<br />- Digicel will not be responsible for: (1) technical failures of any kind, including, but not limited to malfunctions, interruptions, or disconnections in network connections or hardware or software; (2) unauthorized human intervention in any part; or (3) technical or human error which may occur in the administration of this promotion.<br />- Digicel reserves the right to at any time vary the terms of the promotion, to amend its terms and conditions or to withdraw the promotion. In any of these events, notice will be given via media advertisements or messages to subscribers and will be effective immediately or as of the date referred to in such notifications.<br />- Digicel reserves the right to terminate, cancel, suspend and/or modify the promotion if any fraud, virus or other technical problem corrupts the administration, security, safety or proper play of the promotion. In such event, Digicel hereby specifically reserve the right (but not the obligation) to award some other prize hereunder by means of a random drawing from among the eligible entries received up until the time of the impairment.<br /><br /><img alt=\"\" src=\"https://i.postimg.cc/65qDk2ST/Haiti-Independence-PNG.png\" style=\"height:650px; width:650px\" />",
"startDate": "2021-01-01 10:00:00",
"endDate": "2021-01-02 09:59:00",
"startDate": "2021-01-01T10:00",
"endDate": "2021-01-02T09:59",
"denominations": "USD 10 and up",
"localDenominations": null
},
Expand All @@ -102,8 +102,8 @@
"title": "Digicel Haiti From 24 Dec 2020 00:00 To 31 Dec 2020 23:59 (GMT-05:00)",
"title2": "Bonus 3X to 4X",
"description": "<br />-&nbsp;The promotion will run from 00:01 am Thursday, December 24th 2020, through to and including 11:59 pm Thursday, December 31st 2020 (&ldquo;The Promotion Period&rdquo;).<br />- See below the participant denominations for this promotion:<br />&nbsp; &nbsp;- For USD$10 / CAD$ 15/ GBP$ 8 / Local Price 500 HTG, Customers will receive&nbsp; 200% Bonus Credit<br />&nbsp; &nbsp;- For&nbsp; USD$15 / CAD$ 20 /&nbsp; GBP$12 / Local Price 875 HTG, Customers will receive&nbsp; 300% Bonus Credit<br /><br />-&nbsp;The bonus minutes/credit is valid on the recipient&rsquo;s mobile number for a total of 3 days from when it is applied.<br />- The bonus credit on the recipient&rsquo;s Digicel mobile number can be used for Digicel to Digicel (on-net) calls only.<br />- Postpaid customers and Home and Entertainment customers are not eligible for the promotion.<br />- This promotion is only valid for Prepaid Digicel customers.<br />- Digicel will not be responsible for: (1) technical failures of any kind, including, but not limited to malfunctions, interruptions, or disconnections in network connections or hardware or software; (2) unauthorized human intervention in any part; or (3) technical or human error which may occur in the administration of this promotion.<br />- Digicel reserves the right to at any time vary the terms of the promotion, to amend its terms and conditions or to withdraw the promotion. In any of these events, notice will be given via media advertisements or messages to subscribers and will be effective immediately or as of the date referred to in such notifications.<br />- Digicel reserves the right to terminate, cancel, suspend and/or modify the promotion if any fraud, virus or other technical problem corrupts the administration, security, safety or proper play of the promotion. In such event, Digicel hereby specifically reserve the right (but not the obligation) to award some other prize hereunder by means of a random drawing from among the eligible entries received up until the time of the impairment.<br /><br /><img alt=\"\" src=\"https://i.postimg.cc/q7vQX0Xy/image001-69.png\" style=\"height:650px; width:650px\" />",
"startDate": "2020-12-24 10:00:00",
"endDate": "2021-01-01 09:59:00",
"startDate": "2020-12-24 10:00:00Z",
"endDate": "2021-01-01 09:59:00Z",
"denominations": "USD 10 and 15",
"localDenominations": null
}
Expand Down
Loading