Ensure all our rdfs: properties are defined in core RO-Crate profile #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #466 we use
rdfs:properties however these are not all defined in the core RO-Crate profile. This addsrdfs:comment,rdfs:label,rdfs:subClassOf,rdfs:subPropertyOfwith links to the RDFS specification, which inconveniently is not resolved from the@iditself. I've also added definition ofdomainIncludesandrangeIncludeand used these here in schema.org-style-schema way.As this is not modifying the spec itself, I think it's sufficient to version as a patch update (1.2.1).