Skip to content

md5: minor optimization in software backend #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

md5: minor optimization in software backend #755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5bdc8
md5: minor optimization in software backend
newpavlov Nov 6, 2025
bc73dde
tweak comment
newpavlov Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion md5/src/compress/soft.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ fn op_f(w: u32, x: u32, y: u32, z: u32, m: u32, c: u32, s: u32) -> u32 {
}
#[inline(always)]
fn op_g(w: u32, x: u32, y: u32, z: u32, m: u32, c: u32, s: u32) -> u32 {
((x & z) | (y & !z))
// We replace the logical OR in `(x & z) | (y & !z)` with addition.
// Since masked bits do not overlap, the expressions are equivalent;
// however, addition results in better performance on high-end CPUs,
// likely due to improved ALU utilization.
((x & z).wrapping_add(y & !z))
.wrapping_add(w)
.wrapping_add(m)
.wrapping_add(c)
Expand Down