-
Notifications
You must be signed in to change notification settings - Fork 29
Simplify AMS/IAS flow #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
finkmanAtSap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, Rene, I was a bit too fast when I said cds add ams fully configures the MTA for deployment because I did not realize that the guide is based on an existing MTA with XSUAA left-overs and includes some non-general configuration for app 2 app communication that requires manual steps.
I think one would need to be careful to keep some manual MTA configuration steps and test it again before making changes.
| npm install @sap/xssec | ||
| ``` | ||
| 4. Make sure you have `@sap/cds-dk` with `version > 8` is installed as a **global** npm module. | ||
| 1. Make sure you have `@sap/cds-dk` with `version > 8` is installed as a **global** npm module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The absolute minimum for the cds add ias and cds add ams commands is 8.6.0 (see https://pages.github.tools.sap/cap/docs/releases/dec24) but I would suggest >= 8.8 because there were some bug fixes for those commands.
| 1. Make sure you have `@sap/cds-dk` with `version > 8` is installed as a **global** npm module. | |
| 1. Make sure `@sap/cds-dk` with `version >= 8.8` is installed as a **global** npm module. |
| ``` | ||
| 4. Build the project to install the added dependencies | ||
| > This adds the needed configuration for AMS as well as IAS. | ||
| 3. Install the added dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might actually be unncessary. I think the add commands runs it but not sure.
| "authorization": { | ||
| "enabled":true | ||
| }, | ||
| "provided-apis": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This information has to be manually added to the MTA before deployment, even if it gets generated.
| "description": "api exposed by incident mgmt app" | ||
| } | ||
| ], | ||
| "display-name": "incident-ias-<unique-id>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also make a manual change to the display-name if the mta is generated because the generated display-name will not contain and it might occur in some screenshots with a unique-id as suffix.
|
|
||
| 1. Update the `mta.yaml` with the following content | ||
|
|
||
| - Change the dependency `incident-management-auth ` in `resources` from `xsuaa` service instance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this tutorial is based on an existing MTA, I'm not sure if deleting and regenerating it will work fine. If not, we need to keep these manual steps to make sure that we do not have any XSUAA left-overs
| ``` | ||
| - Update `incident-management-srv-api` destination in `incident-management-destination-service` | ||
|
|
||
| - Add `HTML5.IASDependencyName: incidents-api` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is Workzone specific configuration that is not part of the general cds add ias setup, so we need to keep this manual step
No description provided.