Skip to content

Conversation

jboix
Copy link
Member

@jboix jboix commented Aug 29, 2025

Description

Introduces a complete multi-target build system across the template and packages, simplifying and standardizing builds with multiple outputs.

Changes Made

  • Updated create template:

    • Added .build.config.js defining the default build and instructions for adding new targets.
    • vite.config.lib.js and vite.config.umd.js now dynamically import the current build target
      from .build.config.js via the BUILD_TARGET environment variable.
    • The template now ships with multi-output builds by default.
  • Added npm-run-all and rimraf helper scripts to reduce boilerplate in package.json.

  • Updated packages to use the new system:

    • pillarbox-playlist and google-cast-sender plugins now supports multi-output builds.
    • All package build scripts now leverage the helper script to ensure consistency.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

Copy link

github-actions bot commented Aug 29, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 96.93% 4681 / 4829
🔵 Statements 96.93% 4681 / 4829
🔵 Functions 95.15% 334 / 351
🔵 Branches 88.65% 555 / 626
File CoverageNo changed files found.
Generated in workflow #232 for commit 07788f4 by the Vitest Coverage Report Action

@jboix jboix force-pushed the chore/multi-output-build branch from e5c45fd to 576d884 Compare August 29, 2025 08:35
@jboix jboix force-pushed the chore/multi-output-build branch from 576d884 to 3c59dae Compare September 10, 2025 07:39
Copy link

github-actions bot commented Sep 10, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-08 13:04 UTC

@jboix jboix force-pushed the chore/multi-output-build branch from 3c59dae to fce658e Compare September 10, 2025 13:55
@jboix jboix self-assigned this Sep 18, 2025
@jboix jboix added this to Pillarbox Sep 18, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Sep 18, 2025
@jboix jboix moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Sep 18, 2025
@jboix jboix marked this pull request as ready for review September 18, 2025 07:33
@jboix jboix force-pushed the chore/multi-output-build branch from fce658e to f86ee62 Compare September 18, 2025 07:38
@jboix jboix force-pushed the chore/multi-output-build branch 2 times, most recently from 0d889af to fc8c830 Compare October 2, 2025 14:50
@jboix jboix requested a review from amtins October 2, 2025 14:53
@jboix jboix force-pushed the chore/multi-output-build branch from fc8c830 to d7b5b89 Compare October 2, 2025 15:01
Introduces a complete multi-target build system across the template and packages, simplifying and
standardizing builds with multiple outputs.

Changes include:

- Updated `create` template:
  - Added `.build.config.js` defining the default build and instructions for adding new targets.
  - `vite.config.lib.js` and `vite.config.umd.js` now dynamically import the current build target
    from `.build.config.js` via the `BUILD_TARGET` environment variable.
  - The template now ships with multi-output builds by default.

- Added `npm-run-all` and `rimraf` helper scripts to reduce boilerplate in `package.json`.

- Updated packages to use the new system:
  - `pillarbox-playlist` and `google-cast-sender` plugins now supports multi-output builds.
  - All package `build` scripts now leverage the helper script to ensure consistency.
@jboix jboix force-pushed the chore/multi-output-build branch from d7b5b89 to 07788f4 Compare October 2, 2025 15:05
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you!

@jboix jboix merged commit 4567784 into main Oct 8, 2025
5 checks passed
@jboix jboix deleted the chore/multi-output-build branch October 8, 2025 13:03
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Oct 8, 2025
Copy link

🎉 This PR is included in version @srgssr/google-cast-sender-v1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version @srgssr/pillarbox-playlist-v3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants