Skip to content

Resolved blocker and critical sonar issues. Fixes #347 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolved blocker and critical sonar issues. Fixes #347 #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc6364d
Resolved blocker and critical sonar issues. Fixes #347
SangameshItagi Feb 15, 2022
ef2de0c
Spotless check validations
SangameshItagi Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/sasanlabs/controller/exception/ControllerExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class ControllerExceptionHandler extends ResponseEntityExceptionHandler {

private MessageBundle messageBundle;

private static final transient Logger LOGGER =
private static final transient Logger LOG =
LogManager.getLogger(ControllerExceptionHandler.class);

public ControllerExceptionHandler(MessageBundle messageBundle) {
Expand All @@ -31,15 +31,15 @@ public ControllerExceptionHandler(MessageBundle messageBundle) {
@ExceptionHandler(ControllerException.class)
public ResponseEntity<String> handleControllerExceptions(
ControllerException ex, WebRequest request) {
LOGGER.error("Controller Exception Occurred :-", ex);
LOG.error("Controller Exception Occurred :-", ex);
return new ResponseEntity<String>(
ex.getExceptionStatusCode().getMessage(ex.getArgs(), messageBundle),
HttpStatus.INTERNAL_SERVER_ERROR);
}

@ExceptionHandler(Exception.class)
public ResponseEntity<String> handleExceptions(Exception ex, WebRequest request) {
LOGGER.error("General Exception Occurred :- ", ex);
LOG.error("General Exception Occurred :- ", ex);
return new ResponseEntity<String>(
ExceptionStatusCodeEnum.SYSTEM_ERROR.getMessage(null, messageBundle),
HttpStatus.INTERNAL_SERVER_ERROR);
Expand Down
28 changes: 14 additions & 14 deletions src/main/java/org/sasanlabs/internal/utility/FrameworkConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,24 @@
*
* @author [email protected] KSASAN
*/
public interface FrameworkConstants {
public class FrameworkConstants {

// Site map related constants
String GENERAL_XML_HEADER = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n";
String SITEMAP_URLSET_TAG_START =
public static final String GENERAL_XML_HEADER = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n";
public static final String SITEMAP_URLSET_TAG_START =
"<urlset xmlns=\"http://www.sitemaps.org/schemas/sitemap/0.9\" >\n";
String SITEMAP_URL_TAG_START = "<url>";
String SITEMAP_URL_TAG_END = "</url>";
String SITEMAP_LOC_TAG_START = "<loc>";
String SITEMAP_LOC_TAG_END = "</loc>";
String SITEMAP_URLSET_TAG_END = "</urlset>";
public static final String SITEMAP_URL_TAG_START = "<url>";
public static final String SITEMAP_URL_TAG_END = "</url>";
public static final String SITEMAP_LOC_TAG_START = "<loc>";
public static final String SITEMAP_LOC_TAG_END = "</loc>";
public static final String SITEMAP_URLSET_TAG_END = "</urlset>";

String HTTP = "http://";
String HTTPS = "https://";
String COLON = ":";
String SLASH = "/";
String NEXT_LINE = "\n";
public static final String HTTP = "http://";
public static final String HTTPS = "https://";
public static final String COLON = ":";
public static final String SLASH = "/";
public static final String NEXT_LINE = "\n";

// As VulnerableApp is added to each URL hence creating a constant for reference.
String VULNERABLE_APP = "VulnerableApp";
public static final String VULNERABLE_APP = "VulnerableApp";
}
8 changes: 5 additions & 3 deletions src/main/java/org/sasanlabs/service/impl/EndPointsInformationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public class EndPointsInformationProvider implements IEndPointsInformationProvid

int port;

private static final String APP_TEMPLATES_PATH = "/VulnerableApp/templates/";

public EndPointsInformationProvider(
EnvUtils envUtils,
MessageBundle messageBundle,
Expand Down Expand Up @@ -148,15 +150,15 @@ private void addFacadeResourceInformation(
Arrays.asList(
new ResourceURI(
false,
"/VulnerableApp/templates/"
APP_TEMPLATES_PATH
+ facadeVulnerabilityDefinition.getName()
+ "/"
+ template
+ ".css",
ResourceType.CSS.name()),
new ResourceURI(
false,
"/VulnerableApp/templates/"
APP_TEMPLATES_PATH
+ facadeVulnerabilityDefinition.getName()
+ "/"
+ template
Expand All @@ -165,7 +167,7 @@ private void addFacadeResourceInformation(
resourceInformation.setHtmlResource(
new ResourceURI(
false,
"/VulnerableApp/templates/"
APP_TEMPLATES_PATH
+ facadeVulnerabilityDefinition.getName()
+ "/"
+ template
Expand Down
6 changes: 1 addition & 5 deletions src/main/java/org/sasanlabs/service/vulnerability/commandInjection/CommandInjection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,7 @@ public ResponseEntity<GenericVulnerabilityResponseBean<String>> getVulnerablePay
.find()
&& !requestEntity.getUrl().toString().toUpperCase().contains("%26")
&& !requestEntity.getUrl().toString().toUpperCase().contains("%3B")
& !requestEntity
.getUrl()
.toString()
.toUpperCase()
.contains("%7C");
&& !requestEntity.getUrl().toString().toUpperCase().contains("%7C");
return new ResponseEntity<GenericVulnerabilityResponseBean<String>>(
new GenericVulnerabilityResponseBean<String>(
this.getResponseFromPingCommand(ipAddress, validator.get()).toString(),
Expand Down
Loading