Add missing LinearVerbosity imports to extensions #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several extensions were using LinearVerbosity in their function signatures but were not explicitly importing it. This commit adds the missing imports to ensure proper functionality: - LinearSolveIterativeSolversExt: Added LinearVerbosity to imports - LinearSolveFastLapackInterfaceExt: Added LinearVerbosity import - LinearSolvePardisoExt: Added LinearVerbosity to imports - LinearSolveSparspakExt: Added LinearVerbosity import These imports are necessary as LinearVerbosity is used as a type annotation in the init_cacheval functions of these extensions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing
LinearVerbosityimports to several extensions that were using it in their function signatures but not explicitly importing it.Changes
The following extensions now properly import
LinearVerbosity:LinearVerbosityto the existingusing LinearSolve:statementusing LinearSolve: LinearVerbositylineLinearVerbosityto the existingusing LinearSolve:statementusing LinearSolve: LinearVerbositylineContext
These imports are necessary as
LinearVerbosityis used as a type annotation in theinit_cachevalfunctions of these extensions. While the code may have worked due to Julia's module system, explicit imports ensure better code clarity and prevent potential issues.Test Plan
using LinearSolveLinearVerbosity()can be created and used🤖 Generated with Claude Code