Fix CUDA functional check in init_cacheval functions #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CUDA.functional()
check before creating CUDA arrays ininit_cacheval
functionsnothing
if CUDA is loaded but not functionalCudaOffloadLUFactorization
andCudaOffloadQRFactorization
would fail during cache initialization when CUDA is in environment but not usableDetails
The issue occurs when CUDA.jl is loaded in the environment but
CUDA.functional()
returnsfalse
(e.g., in CI environments without actual CUDA hardware). Theinit_cacheval
functions for CUDA algorithms were trying to createCuVector
andCuMatrix
objects without checking if CUDA is functional, causing failures during default algorithm initialization.Changes
CUDA.functional()
check before creatingCuVector
andCuMatrix
ininit_cacheval
CUDA.functional()
check before creatingCUDA.CuArray
ininit_cacheval
nothing
when CUDA is not functional, matching the fallback behavior when the extension isn't loadedTest plan
init_cacheval
returnsnothing
when CUDA not functionalCloses #761
🤖 Generated with Claude Code