Skip to content

Conversation

MartinuzziFrancesco
Copy link
Collaborator

@MartinuzziFrancesco MartinuzziFrancesco commented Aug 22, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This PR refactors ReservoirComputing.jl to build on LuxCore. Closes #206, #202

@MartinuzziFrancesco MartinuzziFrancesco linked an issue Aug 23, 2025 that may be closed by this pull request
@MartinuzziFrancesco
Copy link
Collaborator Author

MartinuzziFrancesco commented Aug 23, 2025

Some naming things to decide:

  • signature fro train! either
    • train!(rc, train_data, target_data, ps, st, sr::StandardRidge=StandardRidge(0.0)) (current)
    • train!(rc, train_data, target_data, sr::StandardRidge=StandardRidge(0.0), ps, st)
  • name of the collect states function (there a problem with the states nomenclature too, considering Lux as st as states)
    • collectstates (current)
    • collect_reservoirstates
    • collect_reservoir_states
  • collection layer
    • Collect() (current)
    • CollectLayer()
  • readout layer
    • Readout() (current)
    • LinearReadout() even if it could be not linear, this reflects that it is obtained through linear regression, and I actaully like it more at the moment
  • train! or fit!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build on LuxCore Feed data to train instead of ESN
1 participant