Skip to content

Conversation

Joannall
Copy link
Collaborator

@Joannall Joannall commented Sep 11, 2025

PR Type

Enhancement


Description

  • Add Indication property to SQL select function

  • Improve chart generation instructions for multiple charts

  • Enhance report summary formatting requirements


Diagram Walkthrough

flowchart LR
  A["SqlSelect Function"] --> B["Add Indication Property"]
  C["Chart Template"] --> D["Multiple Chart Layout"]
  C --> E["Report Summary Enhancement"]
Loading

File Walkthrough

Relevant files
Enhancement
SqlSelect.cs
Add indication property to SQL function                                   

src/Plugins/BotSharp.Plugin.SqlDriver/UtilFunctions/SqlSelect.cs

  • Reorder property declarations for better organization
  • Add new Indication property with value "Extracting data"
+2/-1     
util-chart-plot_instruction.liquid
Improve chart generation and reporting instructions           

src/Plugins/BotSharp.Plugin.ChartHandler/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/templates/util-chart-plot_instruction.liquid

  • Add instruction for multiple chart layout arrangement
  • Add requirement to use only provided dataset
  • Enhance report summary formatting with bold key findings
  • Specify heading level requirements for structured content
+3/-2     

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Interface Contract

The new Indication property may require updating the IFunctionCallback interface and any consumers. Verify interface compatibility, default behaviors, and downstream usage.

public string Name => "util-db-sql_select";
public string Indication => "Extracting data";
Wording/Clarity

The instruction "Only using the dataset provided..." is grammatically awkward. Consider rewording to "Only use the dataset provided..." to avoid ambiguity for template consumers.

** Only using the dataset provided in the context, NEVER generate or assume any additional dataset on your own. 
Layout Specificity

The multiple charts layout requirement lacks concrete guidance (e.g., flex/grid usage or container sizing). Consider adding minimal, specific layout directives to reduce inconsistent outputs.

** When generating code for multiple charts, arrange them in a clear layout and make sure they do not overlap.
** Only using the dataset provided in the context, NEVER generate or assume any additional dataset on your own. 

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@Oceania2018 Oceania2018 merged commit 202c271 into SciSharp:master Sep 11, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants