refine chart plot prompt

[iceljc]

PR Type

Enhancement

---

Description

• Added type safety requirements for chart plotting

• Enhanced error prevention for mathematical operations

---

Diagram Walkthrough

flowchart LR
  A["Chart Plot Template"] --> B["Type Safety Check"]
  A --> C["Math Operation Validation"]
  B --> D["Enhanced Chart Rendering"]
  C --> D

Loading

File Walkthrough

Relevant files

Enhancement

util-chart-plot_instruction.liquid Enhanced chart plotting safety requirements                            src/Plugins/BotSharp.Plugin.ChartHandler/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/templates/util-chart-plot_instruction.liquid Added requirement for type checking before method application Added requirement for validating mathematical operations Enhanced code safety guidelines for chart plotting +2/-0

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Ambiguity The added guidance about type checks and division by zero is good, but may be too generic. Consider clarifying expected fallback behavior (e.g., how to handle NaN, Infinity, or non-numeric strings) to ensure consistent chart outputs across implementations. ** You must ensure the method is applied on variable with correct type, such as never applying "toFixed" to a non-number variable. Use explicit conversion if necessary. ** You must ensure the math operations are valid, such as avoid dividing by zero. ** Please ensure the code can be executed and the charts are rendered correctly. Consistency Since this is a Liquid template instruction, specify the exact JavaScript patterns to use for type coercion (e.g., Number(x), parseFloat(x), Number.isFinite) and error handling, to avoid inconsistent approaches among agents. ** You must ensure the method is applied on variable with correct type, such as never applying "toFixed" to a non-number variable. Use explicit conversion if necessary. ** You must ensure the math operations are valid, such as avoid dividing by zero. ** Please ensure the code can be executed and the charts are rendered correctly.

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Strengthen numeric type validation Make the type-safety requirement explicit about validating numeric coercion before method calls. Instruct to coerce with Number(...)/parseFloat(...) and verify with Number.isFinite(...) before using methods like toFixed to prevent runtime errors. src/Plugins/BotSharp.Plugin.ChartHandler/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/templates/util-chart-plot_instruction.liquid [35] -** You must ensure the method is applied on variable with correct type, such as never applying "toFixed" to a non-number variable. Use explicit conversion if necessary. +** You must ensure methods are invoked only on values of the correct type (e.g., never call "toFixed" on a non-number). Coerce with Number(value) or parseFloat(value), then validate with Number.isFinite(value) before using numeric methods. Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion improves the instruction by providing specific methods for type coercion and validation (Number(), parseFloat(), Number.isFinite()), which can lead to more robust generated code by the AI agent.	Low
	Harden division and math guards Expand the math-safety rule to require checks for zero and non-finite denominators, and handling of NaN/Infinity. This prevents invalid values from propagating into chart options and causing render failures. src/Plugins/BotSharp.Plugin.ChartHandler/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/templates/util-chart-plot_instruction.liquid [36] -** You must ensure the math operations are valid, such as avoid dividing by zero. +** You must ensure math operations are valid: check denominators for 0 or non-finite before division, and guard against NaN/Infinity (e.g., default to 0 or skip the calculation). Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion enhances the instruction for math operations by explicitly mentioning checks for non-finite denominators and handling of NaN/Infinity, making the guidance for the AI agent more comprehensive and likely to produce safer code.	Low
More